Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar component #1325

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Calendar component #1325

merged 5 commits into from
Dec 5, 2023

Conversation

matheusps
Copy link
Contributor

@matheusps matheusps commented Nov 30, 2023 •
edited
Loading

Summary

  • Create the calendar component
  • Create the store package
  • Improve locale to support react-aria components
  • Add invariant() util
  • Add warning() util
  • Add extended-components layer

Examples

<Calendar />

Controled

const now = today(getLocalTimeZone())
const [value, setValue] = useState(now)

<Calendar value={value} onChange={setValue} />

Localized

<LocaleProvider locale="en-US">
  <Calendar />
</LocaleProvider>

@matheusps matheusps self-assigned this Nov 30, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shoreline-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 0:49am

@github-actions GitHub Actions
Copy link

Hi @matheusps! Thanks for opening this PR. Please set the applicable project fields and labels to this PR to improve our workflow. You can do this by clicking on the "Projects" tab on the right side of the PR page and expanding the tab to set other fields, and by clicking on the "Labels" tab on top of it and selecting the applicable labels.

Base automatically changed from feature/date to main December 1, 2023 15:39
@matheusps matheusps marked this pull request as ready for review December 4, 2023 21:04
@matheusps matheusps requested a review from a team as a code owner December 4, 2023 21:04
@matheusps matheusps changed the title feat(calendar): add component Calendar component Dec 4, 2023
lucasaarcoverde
lucasaarcoverde approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@lucasaarcoverde lucasaarcoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

packages/date/src/calendar/calendar-provider.tsx Outdated Show resolved Hide resolved
packages/date/src/calendar/calendar.tsx Outdated Show resolved Hide resolved
packages/date/src/calendar/calendar.tsx Outdated Show resolved Hide resolved
packages/theme/src/preflight.css Outdated Show resolved Hide resolved
marcelovicentegc
marcelovicentegc approved these changes Dec 5, 2023
View reviewed changes
packages/components/src/locale/locale-provider.tsx
Comment on lines +18 to +19
{/** Some react-aria components require this to translate */}
<I18nProvider locale={locale}>{children}</I18nProvider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use their provider instead then? Or maybe port whatever makes this required to our own locale provider? It seems to me that it does the same job we're doing here.

Or maybe just use the provider from react-aria on the components that require it.

Ref: https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/i18n/src/context.tsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried using it on each component, but it caused DX issues since it must wrap the hooks. Though in using the locale instead of wrapping it - buuut it would make the lib stuck on react-aria to do intl even in non-react-aria components. So, I've decided to plug into the LocaleProvider :)

packages/date/src/calendar/calendar-cell.tsx Show resolved Hide resolved
@matheusps matheusps merged commit 6dd5f67 into main Dec 5, 2023
4 checks passed
@matheusps matheusps deleted the feature/calendar branch December 5, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelovicentegc marcelovicentegc marcelovicentegc approved these changes

@lucasaarcoverde lucasaarcoverde lucasaarcoverde approved these changes

Assignees

@matheusps matheusps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheusps @lucasaarcoverde @marcelovicentegc